Repository navigation
fix(keymap): keep which-key popup working in diff panes - #586
Open
jchenatcpacket wants to merge 1 commit into
Open
jchenatcpacket wants to merge 1 commit into
jchenatcpacket wants to merge 1 commit into
Conversation
which-key installs a buffer-local nowait <leader> trigger on each buffer. Neovim only honors nowait when that mapping is found before any longer mapping sharing its prefix, and buffer-local mappings are searched newest first. The diff panes show buffers which-key had already attached to, so codediff's later <leader>hs/hu/hr/b/e mappings made <leader> wait the full 'timeoutlen' and the popup never appeared in time. After installing or restoring a mapping, ask which-key (when loaded) to rebuild that buffer, batched once per tick. This is what which-key does itself on LspAttach; it re-adds the trigger as the newest mapping. Fix diagnosed and implemented by Claude (Claude Code). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which-key installs a buffer-local nowait trigger on each buffer. Neovim only honors nowait when that mapping is found before any longer mapping sharing its prefix, and buffer-local mappings are searched newest first. The diff panes show buffers which-key had already attached to, so codediff's later hs/hu/hr/b/e mappings made wait the full 'timeoutlen' and the popup never appeared in time.
After installing or restoring a mapping, ask which-key (when loaded) to rebuild that buffer, batched once per tick. This is what which-key does itself on LspAttach; it re-adds the trigger as the newest mapping.
Fix diagnosed and implemented by Claude (Claude Code).