Repository navigation
Add: AudioManager API for sound effects, music, and dialogue - #14
Open
Trident35ro wants to merge 2 commits into
Open
Trident35ro wants to merge 2 commits into
Trident35ro wants to merge 2 commits into
Conversation
Wraps AudioControl so mods can play SFX/dialogue, control battle and background music, and register custom tracks into the exploration music rotation. Behavior (PickSong's selection logic, PlayBattleMusic's no-op-if-playing gate, etc.) was recovered from libil2cpp.so via IDA since managed sources only expose stripped method bodies. No unit tests: IAudioControl needs AudioClip, and the Tests project has no Unity/game interop reference, same as Chunks. Wired into HAMHMod.Load().
Explicitly selecting the overload via new Type[] { typeof(string[]) }
failed to resolve at runtime, throwing and aborting Harmony's PatchAll()
foreach before the battle-music patches applied (same failure class as
the ChunkControl_HostGetChunk_Patch fix). PickSong isn't overloaded, so
patching by name only sidesteps it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps AudioControl so mods can play SFX/dialogue, control battle and background music, and register custom tracks into the exploration music rotation. Behavior (PickSong's selection logic, PlayBattleMusic's no-op-if-playing gate, etc.) was recovered from libil2cpp.so via IDA since managed sources only expose stripped method bodies. No unit tests: IAudioControl needs AudioClip, and the Tests project has no Unity/game interop reference, same as Chunks.
Wired into HAMHMod.Load().