Repository navigation
iOS: keep the screen on while phrasedeck is in front - #160
Merged
Merged
Conversation
Closes #159. Assisted-by: Claude Code:claude-opus-5-5
Skeyelab
enabled auto-merge (squash)
October 27, 2026 14:20
Skeyelab
disabled auto-merge
October 27, 2026 14:23
Skeyelab
enabled auto-merge (squash)
October 27, 2026 14:23
Member
Author
|
agent3 reviewed: pass. Following its note, this is now "Part of #159", with a squash body that won't close the issue, so the real-phone check stays open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #159. The real-phone check stays open on #159 until Eric's TestFlight build.
The app sets
UIApplication.shared.isIdleTimerDisabledfromscenePhase: true while the app is active, false when it's inactive or in the background. It runs withinitial: true, so it also applies at launch. There's no setting for it.The mapping is a small pure function,
KeepAwake.idleTimerDisabled(for:), so it has a unit test.Tests (/tdd)
KeepAwakeTestsfailed to build withcannot find 'KeepAwake' in scope.xcodebuild test -only-testing:PhrasedeckTestspassed, 225 tests in 27 suites.Not checked: that the screen actually stays on with a real phone. Eric checks that with the next TestFlight build.