Repository navigation
American spelling - #143
Merged
Merged
Conversation
Switch prose, comments and local names to American spelling so the org-wide spelling check passes. Claude-Session: https://claude.ai/code/session_01XGS7UUxZFhvaK4bnErEfvW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the repo to American spelling so the org-wide spelling check passes.
Fixed (about 200 hits in 100 files): comments, docs, ADRs, task tickets, CHANGELOG and README prose (colour, behaviour, initialise, grey, licence, quantisation, normalised and so on). Also:
X32Link/web_config.cpp("colors also set the beat LED");RUN_TEST:test_reset_zeroes_dropped_so_it_is_always_initialized,test_flash_rgb_invalid_bar_uses_beat_color,test_running_color_tells_free_from_link.No config keys, NVS keys, JSON fields or routes changed (they already used
color).Allowlisted:
path: lib/unity/in a new.american-spelling-allow, because it is the vendored ThrowTheSwitch Unity test framework.Tests:
make -C test(54 suites, 586 tests, 0 failures),make -C tests run(7 passed),test/check_docs.shpassed. Firmware builds (arduino-cli / ESP-IDF) were not run locally; only comments and one UI hint string changed in firmware sources, and CI builds them.https://claude.ai/code/session_01XGS7UUxZFhvaK4bnErEfvW