Repository navigation
Pure single-button transport gesture (TAP/HOLD) — ESP-045 core - #140
Merged
Merged
Conversation
…P-045) The Mini's one live button needs two gestures: short press = play/stop, hold = realign. transport_button_update() splits a debounced press into TAP (on release) or HOLD (fired once at a 600ms threshold, while still down; the release then stays silent). Pure timing over buttons.c debounce — the glue owns only the pin read and mapping TAP->toggle / HOLD->realign, so the short-vs-long decision is host-tested. Lives in KitchenSync/main/ (transport is a KitchenSync concept, not X32Link). TDD: test_transport_button.c — tap, hold-once-then-silent-release, and back-to-back gesture reset. All host suites green. Claude-Session: https://claude.ai/code/session_01F7YsQgso3KNpeXbP5vNVj6
Skeyelab
enabled auto-merge (squash)
July 17, 2026 05:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Mini's one physical button needs two gestures (ESP-045): short press = play/stop,
hold = realign. This lands the pure, host-tested decoder for that split.
KitchenSync/main/transport_button.{h,c}—transport_button_update(raw, now)returnsTAP(short, on release) orHOLD(held ≥600ms, fired once while down; release thensilent). Composes
buttons.cdebounce; no intent/launch-state dependency — glue mapsTAP→play/stop toggle,HOLD→realign.test/test_transport_button.c— tap, hold-once-then-silent-release, back-to-backreset. All host suites green.
Remaining ESP-045 (separate glue, not this PR): GPIO read +
HAS_TRANSPORT_BUTTONwiringand on-hardware verification on the Super Mini.
https://claude.ai/code/session_01F7YsQgso3KNpeXbP5vNVj6