Repository navigation
American spelling - #66
Merged
Merged
Conversation
Renames StoplightGrey to StoplightGray (internal package). GitHub's "cancelled" conclusion value stays as-is, marked spelling: ok. Claude-Session: https://claude.ai/code/session_01XGS7UUxZFhvaK4bnErEfvW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the repo pass the org's American spelling check (
scripts/american_spelling.pyfromericdahl-dev/.github).Fixed (~45 hits):
StoplightGrey->StoplightGray(constant ininternal/aggregator, renamed at every use; the package is internal so no other module can import it).Stoplight.String()returns an emoji, so nothing persisted changes.CONTEXT.md,CLAUDE.md,.scratch/PRD) and test messages: grey, cancelled (where it is prose), colour, behaviour, organisation, favour, recognise(d), summarise(d), neighbour.TestKeepRunHonoursWorkflowFilter->TestKeepRunHonorsWorkflowFilter,TestPacerHonoursRetryAfter->TestPacerHonorsRetryAfter, subtest "all cancelled" -> "all canceled".Kept, with a
spelling: okline marker (no allowlist file):"cancelled"where it is GitHub's own run conclusion value: two lines ininternal/aggregator/aggregator_test.go, one ininternal/alerts/alerts_test.go, two inCONTEXT.mdand one in the.scratch/PRD. Changing those would break matching against the GitHub API.Tests:
go vet ./...clean,go test ./...passes.https://claude.ai/code/session_01XGS7UUxZFhvaK4bnErEfvW