Repository navigation
feat: show Jobs under each PR Workflow - #65
Merged
Merged
Conversation
An expanded PR row listed only its Workflow runs, so a run with one job still going (say docker-image after build-and-test passed) read as a single line, unlike GitHub's checks list. PR runs now fetch their jobs too, through the same helper as branch runs. It is one more call per PR run under an expanded repo, which the ETag cache makes free while the run is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An expanded PR row showed only one line per Workflow run, so CI with a job still running (e.g.
docker-imageafterbuild-and-testpassed) didn't match GitHub's checks list. PR runs now fetch their Jobs, the same way branch runs do.Cost: one more call per PR run under an expanded repo; the ETag cache makes unchanged runs free. Checked live on ndlibrary/api#118: git-green lists docker-image (in progress), build-and-test, and CodeQL's four Analyze jobs, matching GitHub.