Repository navigation
refactor: give stuck alerts their own module - #58
Merged
Merged
Conversation
evaluateStuck and the stuck rules move out of the poller into alerts.Watcher: Observe(repos, now) returns the alerts that fire this cycle. It sees only Snapshots and the clock, so its tests drop the webhook server and hand-built Poller. Also fixes, while the policy moved: - collapsing a Repo no longer reads as a PR recovering, so it no longer restarts the stuck clock - webhooks are sent in the background; a slow endpoint used to block the poll cycle for up to 10s - webhook failures log through logx instead of log.Printf, which wrote over the full-screen dashboard Closes #53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
evaluateStuck and the stuck rules move out of the poller into
alerts.Watcher: Observe(repos, now) returns the alerts that fire this
cycle. It sees only Snapshots and the clock, so its tests drop the
webhook server and hand-built Poller.
Also fixes, while the policy moved:
restarts the stuck clock
the poll cycle for up to 10s
over the full-screen dashboard
Closes #53
Stack created with GitHub Stacks CLI • Give Feedback 💬