Repository navigation
refactor: deepen Run status into one module - #54
Merged
Merged
Conversation
The effective Run status (conclusion, else status) was resolved by hand in 10 places and read through four status tables that disagreed. The aggregator is now the one place that interprets it: Of, Runs, and Stoplight.ActiveFirst. Icons, re-run eligibility, the repo summary and stuck detection all go through it. Behaviour changes that fall out of the single table: - startup_failure is red, matching what f already offered to re-run - requested, waiting and pending are yellow, not grey - stuck alerts cover action_required/startup_failure and queued Also deletes the dead ui/detail.go (BackMsg moves to manage.go). Closes #49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The effective Run status (conclusion, else status) was resolved by hand
in 10 places and read through four status tables that disagreed. The
aggregator is now the one place that interprets it: Of, Runs, and
Stoplight.ActiveFirst. Icons, re-run eligibility, the repo summary and
stuck detection all go through it.
Behaviour changes that fall out of the single table:
Also deletes the dead ui/detail.go (BackMsg moves to manage.go).
Closes #49
Stack created with GitHub Stacks CLI • Give Feedback 💬