Repository navigation
fix: decode the deployment list when Coolify sends it as an object - #1
Merged
Merged
Conversation
Coolify filters /deployments server-side, and Laravel serializes a collection with gaps in its keys as an object keyed by index rather than an array. The client only accepted an array, so polling failed with "cannot unmarshal object into Go value of type []coolify.Deployment" and the whole instance showed as unreachable. Both shapes now decode, keeping the server's order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polling failed with
coolify unreachable: /deployments: decoding response: json: cannot unmarshal object into Go value of type []coolify.Deployment.Coolify filters
/deploymentsserver-side, and Laravel serializes a collection with gaps in its keys as an object keyed by index rather than an array. The client now accepts both shapes, keeping the server's order, and the pagedLatestDeploymentdecode gets the same treatment.Test:
TestActiveDeploymentsAcceptsKeyedObjectcovers array, keyed object, and empty object. It reproduced the reported error before the fix.🤖 Generated with Claude Code