Repository navigation
fix(relay): make the HTTP fallback work and handle SIGTERM - #82
Merged
Merged
Conversation
The relay's HTTP fallback has never delivered anything:
- it called the pull endpoint with GET, but the route only accepts POST
- it expected a bare array, but the route returns { ok, nodeId, events }
It now POSTs { maxEvents } and reads `events` from the response.
systemd stops the service with SIGTERM, but only SIGINT was handled, so the
graceful shutdown never ran. Both signals now go through registerShutdown().
main() now runs only when relay.ts is executed directly, so the module can be
imported by tests.
Strix Security ReviewNo security issues found. Updated for Reviewed by Strix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The relay's HTTP fallback (used when the WebSocket is down) has never delivered an event:
/api/nodes/pullwith GET, but the route only exportsPOST.{ ok, nodeId, events }, soArray.isArray(...)was false and it returned silently.Separately, systemd stops
clawproxy-relay.servicewithSIGTERM, but onlySIGINTwas handled, so the graceful shutdown path never ran.Change
POST, a JSON body of{ maxEvents }, and readeventsfrom the response.registerShutdown()handles bothSIGINTandSIGTERM.main()runs only whenrelay.tsis executed directly, so tests can import it. I checked thatyarn tsx relay.ts(the service'sExecStart) andyarn relayboth still runmain().Tests (written first)
tests/relay/relay.test.ts:maxEvents{ events }response are forwarded to Hermes with the right HMAC signature, then ackedyarn vitest run: all pass. Lint clean, no type errors outside tests.After merge
On hermes:
git pullin~/projects/clawproxyandsystemctl --user restart clawproxy-relay, then confirmAuth okin the journal.