Repository navigation
feat: approve or reject manual approval stages from the dashboard - #58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57.
What
Pipelines waiting at a manual approval can now be approved or rejected from aws-green.
ActionData.ApprovalTokenis read from theGetPipelineStatecall we already make each poll (only while the action isInProgress). No new API calls. Parsing is factored intoPipelineDataFromStateso it is unit-testable.StoplightAwaitingApproval, ranked between yellow and red, raised instate.FromDatafrom the token. Sorts to the top of the dashboard; stage and action rows show a magenta ⏸ and thea/xhint.a/xkeys -fix.PlanApprovalbuilds an approve/reject plan, confirmed with the existing enter/esc flow.PutApprovalResultis sent with a fixed summary (Approved via aws-green/Rejected via aws-green). The smart fix (f) never approves.InvalidApprovalTokenException/ApprovalAlreadyCompletedExceptionmap toErrApprovalAlreadyDecided, shown as "already decided elsewhere - refreshing" and followed by a re-poll.AccessDenied*maps toErrApprovalNotPermitted, shown as "profile X can't approve - it needs codepipeline:PutApprovalResult".pipeline_stuck. A failed stage still alerts even with an approval open (stage statuses can come from different executions).CONTEXT.md(resolves the open "manual approval" ambiguity).Decisions from #57's open questions
a/xTesting
go test ./...andgolangci-lintclean.testlibnd(AdministratorAccess). Inlibndvia the read-onlylibnd-viewprofile, the approval shows as ⏸ but cannot be decided, which is what the new access-denied message covers.