Repository navigation
Sound delay: close out #68 part 1 (test for settings saved before the delay) - #181
Merged
Merged
Conversation
) The setting itself shipped in #101; this was the one acceptance point without a test. Assisted-by: Claude Code:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #68
The manual sound delay (part 1 of #68) was already built and merged in #101 (
4e44383), then extended to sound early (-500 to 500 ms). Checked against #68's criteria:frontend/src/audio/soundDelay.browser.test.ts, "delays video sound by the setting" (300 ms: 250 to 380)frontend/src/audio/videoAudio.ts(createDelay, connected to the destination)frontend/index.html#sound-delay,applySoundDelaysettings.jsonsound_delay(engine/cameras.py); reload covered intest_a_sound_delay_lines_video_sound_up_with_the_projectors_late_picturetest_settings_saved_before_the_sound_delay_load_it_as_zeroThe new test was mutation-checked: with the default changed to 40, it fails (and so do 3 other tests); with the default restored, everything passes.
The follow-up, auto-measuring the delay with the camera and mic plus the real-rig check, is #180.
Tests
uv run pytest -q: 292 passed, 11 skippednpx tsc --noEmit: OKnpx vitest run --maxWorkers=2: 394 passed, 1 skipped