Repository navigation
Camera mask: drawn areas are skipped; framing shows its outline (#170) - #176
Merged
Merged
Conversation
The UX review found the camera mask doing the opposite of its name: "Mask area" (help: "skip a window, a TV or shiny things") kept ONLY the drawn area, so drawing around a window scanned only the window and wasted a scan. The maintainer chose "skip what I draw". - Engine: apply_camera_mask drops camera pixels inside the drawn areas; everything else is scanned. No saved masks existed to convert. - Editor: "Skip an area" / "Skipping 2 areas" / "Skip nothing"; the help text says to draw around what to leave out; skipped areas are shaded red on the preview; clicking one removes just that area; while drawing, the note says where to click. - Check framing turns the preview on so its outline is visible; choosing another camera clears the old framing outline and note. - README and docs/http-api.md describe skipped areas. Tests: skipped areas yield nothing and the rest is untouched (decode and full-scan API, red first); wording; one area removed of two; preview shown after framing; framing result cleared on camera change. Closes #170 Assisted-by: Claude Code:claude-opus-5-5 Claude-Session: https://claude.ai/code/session_01XGS7UUxZFhvaK4bnErEfvW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The camera mask kept only what was drawn, while its button and examples said 'skip'. Now drawn areas are skipped (the maintainer's choice), shaded on the preview, removable one at a time; Check framing shows the preview with its outline, and a camera change clears the old result. Details in the commit.
Closes #170
https://claude.ai/code/session_01XGS7UUxZFhvaK4bnErEfvW