Repository navigation
Deleting a kept stand-in Take from the Device unlists the stand-in on the Drive (#947) - #954
Merged
Merged
Conversation
… the Drive's Take.json (#947) Assisted-by: Claude Code:claude-sonnet-5-5
Skeyelab
enabled auto-merge (squash)
October 24, 2026 02:49
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #947.
Release now clears
standInsin the Drive'sTake.jsonafter the Device's Take is removed, as a move or recovery does. Chosen over making readers ignore a stale entry: the Drive's file no longer depends on how the stand-in went away (#879's invariant).releasedtest still pins the Drive byte for byte.Tests (red first: the Drive still listed the stand-in): unlisted after Release with only that field changed; put back after a Drive change keeps the listing. Checked by tests and VERIFY_QUICK only, no device. Not real-time path.