Repository navigation
Delete code only tests used: Mix Hold undo, shared headamp, Pre-roll snapshot (#885) - #953
Merged
Merged
Conversation
…snapshot (#885) Removes MixHold.UndoSet, Plan.undo, Run, apply(_:to:), ChannelSource and channels(movedByHeadamp:sources:), Recorder.isKeepingPreRoll, and PreRollBuffer.snapshot(maxFrames:) with its Snapshot. The PreRollBuffer tests read through read(frames:); tests that only exercised the deleted code go too. No change anyone can see. Assisted-by: Claude Code:claude-sonnet-5-5
Skeyelab
enabled auto-merge (squash)
October 24, 2026 02:00
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #885.
What
Deletes code only tests used, with no change anyone can see (about 290 lines net):
MixHold.UndoSet,Plan.undo,MixHold.Run,MixHold.apply(_:to:),ChannelSourceandchannels(movedByHeadamp:sources:). Production undo isGainStep.restore, and the shared-preamp work (X Air: a gain move changes the mix of another channel on the same preamp #874, X Air: a gain move compensates every channel on the same preamp (#874) #912) doesn't usechannels(movedByHeadamp:). The doc comment that pointed at it is fixed.Recorder.isKeepingPreRoll(no caller at all).PreRollBuffer.snapshot(maxFrames:)andSnapshot. The PreRollBuffer tests, andPreRollFillTests, now read throughread(frames:), as the issue asks. The torn-read test reads a window near the buffer's capacity so the writer often laps it.Tests
This is a deletion, so there is no red run. Every test that remains passed on its first run after the edit. Tests that only exercised the deleted code were removed: the undo-set and linked-pair tests,
FakeMixer, and two loop tests built onMixHold.Run. Production undo and shared-preamp compensation stay covered by XAirGainTests, X32GainTests and MixHoldLagTests (the Code Reviewer checked this).VERIFY_QUICK=1 ./scripts/verify.shpasses.Timing
Merges right after v1.1.16, not right before a tag. It touches
PreRollBuffer, which is on the real-time path's edge, but only deletes the unusedsnapshotandSnapshot.writeandread(frames:)are unchanged. Checked only by tests.