Repository navigation
Changing Pre-roll or the sample rate while a Take is being saved no longer shows "Couldn't start" (#932) - #951
Merged
Merged
Conversation
…onger shows "Couldn't start" (#932) settingsChanged() re-Armed at once; during a save Arm throws .finishing, so a clean Take was followed by a false error. It now waits for the save like tierChanged, and several changes during one save make one Arm. Assisted-by: Claude Code:claude-sonnet-5-5
Skeyelab
enabled auto-merge (squash)
October 23, 2026 05:16
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #932.
What
TakeSequencer.settingsChanged()re-Armed at once. While a Take is being saved,Recorder.armthrows.finishing, so a clean Take was followed by a red "Couldn't start" error and the change waited for the next Arm. It now waits for the save (recorder.waitWhileFinishing()), astierChangeddoes since #884, and then re-Arms. A flag keeps several changes during one save to one Arm, since each Arm restarts the input and drops Pre-roll.Red first
New test
settingsChangedWhileFinishing(AsyncStopOffMainTests) changes the setting three times during a blocked save. Before the fix: 3 issues (armErrorset right away,armErrorstill set after the save, three Arms instead of one). After: passes. TakeSequencerTests and AsyncStopOffMainTests: 65 pass.VERIFY_QUICK=1 ./scripts/verify.shpasses.Checked only by tests
Not tried on a device. TakeSequencer is on the tag gate in CLAUDE.md: it needs a real-device Take from a TestFlight build before External testers. It rides the internal tag after v1.1.16, not v1.1.16.
Known limits (from review, not fixed here)