Repository navigation
Refactor: the screenshot launch flags move out of RecordScreenModel.start() (#890) - #949
Merged
Merged
Conversation
…tart() (#890) start() ran -demoDrive, -demoNames and -demoRecord inline after the real startup work. They are now runScreenshotFlags(), called last, with the same code in the same order. Assisted-by: Claude Code:claude-sonnet-5-5
Skeyelab
enabled auto-merge (squash)
October 23, 2026 03:56
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One item of #890.
RecordScreenModel.start()ran the screenshot and layout-check launch flags (-demoDrive,-demoNames,-demoRecord) inline after the real startup. They are now a privaterunScreenshotFlags(), called as the last statement ofstart(): the same code in the same order, six lines added and none changed.No red test is possible: it is a pure move with no behavior change. A Code Reviewer compared the body with the old lines (nothing depended on a local of
start(); isolation and the-demoRecordcall to the asyncrecord()are as before)../scripts/verify.sh(full, sinceApp/changed) passes: package tests, macOS build and AppTests, iOS Simulator build. Not run in the Simulator.