Repository navigation
Pro: the license honors a pack on the Armed family; pack plan and Restore wording (#705) - #771
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…tore wording (#705) ProStatus.license(proOffered:armedFamily:now:) passes the Armed input's mixer family through, so a pack on it counts as Pro at record press; without a family it's as before. PackOffer.planTitle names a pack owner's plan ("X Air pack") unless Pro or a running Trial says more; PackOffer.restoreNote says "Restored: X Air pack" when only a pack came back. MixerFamily.name is public for copy. Claude-Session: https://claude.ai/code/session_01K4ihr1i6m1uuUswAENvJKJ Assisted-by: Claude Code:claude-opus-5-5
Skeyelab
force-pushed
the
packs-license-705
branch
from
October 16, 2026 05:37
0916071 to
a1006f8
Compare
Skeyelab
enabled auto-merge (squash)
October 16, 2026 05:37
auto-merge was automatically disabled
October 16, 2026 05:39
Pull request was closed
Skeyelab
enabled auto-merge (squash)
October 16, 2026 05:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#705, Kit. Stacked on #770. Auto-merge goes on once its base is
main. No app change in this PR; the app PR stacked on it uses these.What it adds
ProStatus.license(proOffered:armedFamily:now:): the Armed input's mixer family goes through totier(now:armedFamily:), so a pack on that family counts as Pro at record press. The defaultnilkeeps every existing caller exactly as before.PackOffer.planTitle(tier:ownsPro:ownedPacks:): the plan line in Settings.PackOffer.restoreNote(ownsPro:ownedPacks:):MixerFamily.nameis public, for copy ("X Air", "X32").Tests, written first (
PackOfferTests.licenseWithFamily,planTitle,restoreNote): red (compile: noarmedFamily:, noplanTitle, norestoreNote), then green. None passed on its first run. Review then madelicenseWithFamilyuse one fixed date.Reviewed: a code-review agent found no blockers. Its finding, that a Trial could be hidden by a pack on the Armed family, is handled by the doc rule here and by
ProStore.planLicense()in the app PR.Checked: full package tests (1,034) pass, and
VERIFY_QUICK=1 ./scripts/verify.shpasses.