Repository navigation
Increase unit test coverage (closes #64) - #79
Merged
Merged
Conversation
…outeFactory Covers gaps from issue #64: - TunnelManager: ngrok with keychain token, missing/empty token error, process exit error propagation, duplicate URL suppression (5 new tests) - RouteTests: Compare raw values, all three Route inits, JSON decoding of comparisons map, unknown Compare key throws (7 new tests) - WebhookRouteFactoryTests: nil/empty routes, name/comparison preservation, closure wiring (4 new tests) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PluginManagerTests covers: enabled() true/false/case-insensitive, module count after init, /ping route present in getAllRoutes, reload preserves modules, apply updates disabledCommands and webhooks (10 new tests). Also registers RouteTests, WebhookRouteFactoryTests, and PluginManagerTests in the Xcode project so they compile into the test target. 172 tests total, 0 failures. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Skeyelab
added a commit
that referenced
this pull request
Aug 23, 2026
* Add tests for TunnelManager ngrok paths, Route decoding, and WebhookRouteFactory Covers gaps from issue #64: - TunnelManager: ngrok with keychain token, missing/empty token error, process exit error propagation, duplicate URL suppression (5 new tests) - RouteTests: Compare raw values, all three Route inits, JSON decoding of comparisons map, unknown Compare key throws (7 new tests) - WebhookRouteFactoryTests: nil/empty routes, name/comparison preservation, closure wiring (4 new tests) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Add PluginManagerTests and register new test files in xcodeproj PluginManagerTests covers: enabled() true/false/case-insensitive, module count after init, /ping route present in getAllRoutes, reload preserves modules, apply updates disabledCommands and webhooks (10 new tests). Also registers RouteTests, WebhookRouteFactoryTests, and PluginManagerTests in the Xcode project so they compile into the test target. 172 tests total, 0 failures. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Eric Dahl <edahl@nd.edu> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfigurationHelperandKeychainStoreremain out of scope as noted in the issue)New test files
TunnelManagerTests.swiftRouteTests.swiftCompareraw values, all 3Routeinit forms, JSON decode happy path, multiple comparisons, unknown key throwsWebhookRouteFactoryTests.swiftPluginManagerTests.swiftenabled()true/false/case-insensitive, module count on init,/pingingetAllRoutes,reload()preserves modules,apply()updates disabled commands and webhooksAlso registers the three new test files in
Jared.xcodeprojand addsPluginManager.swiftto the test target sources (required to resolveConfigurationFiletype in the same module as the test target).Test plan
bash ./.github/scripts/test-macos.sh— 172 tests, 0 failures🤖 Generated with Claude Code