[Skeyelab]

Closes #71

Summary

CoreModule was the largest untested built-in RoutingModule (0% coverage, 173 lines) with four try!s on FileManager/Contacts/JSON. This injects side-effect ports so every command is testable, and removes the try!s.

• ContactNameService port + CNContactNameService adapter — /name no longer reaches CNContactStore directly. Adapter does authorization check + search + create-or-update behind one setGivenName(_:forHandle:) that throws instead of try!. Fakeable in tests.
• Clock port (RealClock) — /send's inter-message delay is an injected async sleep, so the send loop runs instantly and deterministically under test.
• SendRateLimiter — per-handle concurrency bookkeeping pulled out of /send into a sync, deterministic unit (replaces the inline currentSends dict + MAXIMUM_CONCURRENT_SENDS).
• Removed the dead FileManager.createDirectory try! in init (the appsupport URL was never used) — init now does no filesystem work and can't crash.
• barf try! → try? + "nil" fallback.
• Extracted performSend(_:text:times:delay:) for an awaitable send loop.

Built with TDD

One behavior per cycle. Simple commands locked as characterization tests first, then new ports driven red→green: SendRateLimiter (acquire/release/per-handle) → /send delivery + concurrency rejection (fake Clock + pre-filled limiter) → ContactNameService (/name auth/validation/create/update/throw) → init no-filesystem.

Test plan

• bash ./.github/scripts/test-macos.sh — 146 tests, all pass (was 125)
• CoreModuleTests — /ping /version /whoami (named + unknown) /barf thanks; /send validation (type/count/delay/text) + delivery + concurrency limit; /name not-authorized / missing-arg / non-text / create+confirm / save-throws; init registers routes with no filesystem side effects
• SendRateLimiterTests — acquire up to max, reject, release frees slot, per-handle quota

Acceptance criteria

• Each built-in command has happy-path test via JaredMock
• /send concurrency limit tested with injectable clock (+ SendRateLimiter)
• /name tested without real Contacts permission
• No new try! on contact operations in production path (and removed the existing ones)
• Existing tests pass

🤖 Generated with Claude Code