Repository navigation
Split WebHookManager into delivery client and route factory - #75
Merged
Merged
Conversation
Extract HTTP/signing/retry logic into WebhookDeliveryClient and route wiring into WebhookRouteFactory; WebHookManager becomes a thin coordinator. sendTest() in the management UI now uses the production delivery path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66
Summary
WebhookDeliveryClient(injectableURLSession,KeychainAccessor)WebhookRouteFactory: produces[Route]with livecallclosures fromRichWebhook— eliminates the "patch empty closure at runtime" pattern fromupdateHooksWebHookManageris now a thin coordinator: owns keychain bootstrapping andMessageDelegate/RoutingModuleconformance; delegates HTTP work to the clientWebhookManagementWindowController.sendTest()now usesWebhookDeliveryClient(same signing/retry/recording path as production) instead of a directURLSession.shared.dataTaskcallWebhookDeliveryTeststo referenceWebhookDeliveryClientstatic methods directlyTest plan
bash ./.github/scripts/test-macos.sh— 106 tests, all passWebhookTestspass (integration viaWebHookManager)WebhookDeliveryTestspass (unit tests updated to targetWebhookDeliveryClient)testWebHookManagerPersistsDeliveryfixed to filter notifications bywm.clientobject (prevents stale notification interference from prior tests)🤖 Generated with Claude Code