Extend SurfaceLayer for all boundary sides - #3860
Open
ckendrick wants to merge 1396 commits into
Open
Conversation
…x_par2mesh_w_terrain
…/sdm_w_cold_processes
# Conflicts: # Source/Microphysics/ERF_LagrangianMicrophysics.H # Source/Microphysics/SuperDropletsMoist/ERF_SuperDropletsMoistInit.cpp # Source/Microphysics/SuperDropletsMoist/ERF_SuperDropletsMoistPhaseChange.cpp # Source/Microphysics/SuperDropletsMoist/ERF_SuperDropletsMoistUtils.cpp # Source/Particles/ERF_SuperDropletPC.H # Source/Particles/ERF_SuperDropletPCUtils.cpp
…x::average_down on RhoTheta+RhoQ_n
… terrain-aware moist state sync
…on AMR coarse/fine boundaries
…to dg/sdm_w_cold_processes
…it kernel for partial-z AMR fabs
…g/sdm_w_cold_processes
…ming heat balance, call snowAccumulation and emit the accumulation fields in canonical order
…heck on graupel accumulation
…_processes # Conflicts: # Source/Particles/ERFPC.H # Source/Particles/ERF_SuperDropletPC.H
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the MOST/Surface Layer boundary condition to be specified on all 6 faces instead of only zlo.
Main changes to
SurfaceLayer/MOSTAverageclasses:SurfaceLayerandMOSTAverageclasses to determine behavior on different faces.erf.most.surf_temp, can now beerf.xlo.most.surf_temp).SurfaceLayerwrites to Tau and heat/moisture flux arrays for each face. Directional velocity averages and orientation is passed to MOSTStress.Main changes to
ERF:SurfaceLayerinstance all 6 faces where the BC type is set tosurface_layer(otherwise nullptr)A follow-up PR will be made to adapt this for the new cloudchamber interface and problem configuration.