Repository navigation
fix: show every version's release notes on the changelog and complete the landing page - #81
Merged
Merged
Conversation
The release image was built from a shallow clone, so the page only listed the release commit. The image now gets the full history, and each tag's range lists its merged pull requests by title.
Their keys existed in no language, so the page showed the raw ??key?? markers.
enimaloc
changed the title
The page now reads the notes edited in the release PR and on the GitHub Releases, not PR titles. Older versions stay listed, including those published without notes.
enimaloc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Résumé
/changelogn'affichait qu'une seule ligne ((release) v1.0.0-BETA.99), cargit logtournait sur un clone à un seul commit dans le build de l'image.La page affiche maintenant les notes de release de toutes les versions :
CHANGELOG.md.ChangelogServicelit un seul fichier,changelog.md, généré au build. En local, c'est une copie deCHANGELOG.md. Le premier commit de la PR (titres de PR et historique git) est remplacé par ce fonctionnement.Landing page
Les cartes Minecraft, Steam et Xbox affichaient
??platforms.*.description_fr_FR??: les clés n'existaient dans aucune langue. Elles sont ajoutées, etSiteCatalogTestvérifie les textes des cartes dans chaque langue.Limites
code) s'affiche brut.Modules à redémarrer
catapult-apietcatapult-webTests
ChangelogServiceTest,ChangelogControllerTest,SiteCatalogTestet les tests des scripts de release passent. Le script a tourné sur les 100 vraies releases avec des notes de test.englishConventionséchoue à cause de commentaires français danscatapult-web-old, sans rapport avec cette PR. Le job de release lui-même n'a pas été exécuté.