Memory properties refactor#59
Merged
Merged
Conversation
…erties from construction params
… newer memory_properties API still in progress
…for replacing memory_properties for constructing vulkan handles
…o vk::physical_device
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #57
This PR simplifies automated memory property to explicit user-defined memory heap indexes.
Previously, the API attempted at automating memory property configuration to simplify handle creation. However, this proved to be quite restrictive to non-standard use-cases and forced users to provide additional, two mandatory parameters for every buffer and image handles.
These changes bring in the newer API for removing passing in the full memory properties struct and replacing with a
uint32_tbit mask of the memory heap index that is being targeted.Changelogs
Memory Property Handle Configurations
VkPhysicalDeviceMemoryPropertiesas mandatory dependency for object construction.uint32_tbit mask. This allows for more direct memory type index retrieval based on the specific handle type.vk::vertex_paramsandvk::index_params. Centralizing all buffer handles construction to usingvl::buffer_parametersto reduce redundancy.property_flagfromvk::buffer_parameters.Utilities API
select_depth_formatandselect_compatible_formatAPI's from utilities.cppm.enumerate_surfacefrom utilities.cppmPhysical Device API
physical_device::request_depth_formatandphysical_device::request_format.request_surfacewith additional parameter for request the specific surface properties.