Repository navigation
Conversation
CI splits the Node suite over 8 shards, each with its own server, so these only fail in a full run against a single server: - The sandbox hook-event test listed the test plugin's events with limit 100; a full run records more. The plugin's events-list route now accepts `ids` for a direct lookup. - The sandbox user-list check required exactly one user, but the passkey setup test adds a second. - In a crowded root folder the dragged media row sat at the viewport's bottom edge, where dnd-kit auto-scrolls and the drop target moves. pointerDrag now scrolls the source to the centre and re-measures the target during the drag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes three Node E2E tests that fail when the whole suite runs against one server. CI splits the suite over 8 shards, each with its own server and database, so CI on
maindoesn't hit these failures. A full local run (pnpm test:e2e, with or withoutEMDASH_E2E_BUILD=production) does, and so does Endform, which runs every test against one shared server.Split out of #6 and #7 so those PRs carry only what a built fixture needs. #8 and #9 include this commit, because Endform needs it.
sandbox-plugin-admin-surfaces.spec.ts: hook eventslimit: 100. A full run records more, so the events it looked for were missing.events-listroute acceptsidsfor a direct lookup, and the test asks for its own two events.sandbox-plugin-boundaries.spec.ts: user listmedia-library.spec.ts: drag into a folderpointerDragscrolls the source to the centre and re-measures the target during the drag.The drag test still fails about 1 run in 3 in a very crowded root folder. That is the "1 failed" in the local production timings on #7.
Related PRs
astro build --devOutputastro builddangerouslyEnableTestHooksoptionastro build --devOutputastro buildastro buildwith a runtime env switchType of change
Your connection to this change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change): the full Node suite on one server, with these fixes, in the native runs on test(e2e): run the Node suite against an astro build --devOutput build #6 and feat(core): add dangerouslyEnableTestHooks and run Node E2E against a production build #7pnpm formathas been run@emdash-cms/plugin-marketplace-testis privateAI assistance disclosure
Screenshots / test output
Not applicable.
🤖 Generated with Claude Code