Repository navigation
fix(connect): fail closed on lost approval context - #214
Merged
LiranCohen merged 1 commit intoSep 18, 2026
Merged
LiranCohen merged 1 commit into
LiranCohen merged 1 commit into
Conversation
LiranCohen
force-pushed
the
fix/connect-approval-preconditions
branch
from
September 18, 2026 14:51
115a603 to
6214282
Compare
LiranCohen
changed the base branch from
fix/connect-override-endpoint-timeout
to
main
September 18, 2026 14:57
LiranCohen
force-pushed
the
fix/connect-approval-preconditions
branch
from
September 18, 2026 14:58
6214282 to
e2b5c70
Compare
LiranCohen
changed the base branch from
main
to
fix/connect-override-endpoint-timeout
September 18, 2026 14:58
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
LiranCohen
force-pushed
the
fix/connect-approval-preconditions
branch
from
September 18, 2026 15:20
e2b5c70 to
1c0038b
Compare
LiranCohen
changed the base branch from
fix/connect-override-endpoint-timeout
to
main
September 18, 2026 15:25
LiranCohen
force-pushed
the
fix/connect-approval-preconditions
branch
from
September 18, 2026 15:25
1c0038b to
82409f8
Compare
LiranCohen
changed the base branch from
main
to
fix/connect-override-endpoint-timeout
September 18, 2026 15:26
LiranCohen
force-pushed
the
fix/connect-approval-preconditions
branch
from
September 18, 2026 20:19
82409f8 to
cc3712a
Compare
LiranCohen
force-pushed
the
fix/connect-approval-preconditions
branch
from
September 18, 2026 20:38
cc3712a to
6f6a5f4
Compare
LiranCohen
force-pushed
the
fix/connect-approval-preconditions
branch
from
September 18, 2026 20:53
6f6a5f4 to
28ecb43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Inline onboarding enters a progress phase before handing off to the approval handler. If the wallet locks or approval context changes in that narrow async window, the old guards returned without changing phase. The user then saw a permanent loader and a second fresh attempt could work.
Stack
Depends on #213. Merge #213 first, then this PR; its diff contains only the approval-context change.
Verification