Repository navigation
Conversation
…giene Two checks that run unattended. The ranking judges every invariant against a pull request, a local checkout, a diff, or an issue, and lists the pages documenting the affected ones, so the PR rule in the freshness policy arrives as a checklist. --pages also ranks the pages no invariant cites; --json and --top serve a calling agent. Comment hygiene is exact — a URL, an issue reference, a severity label, a packet reference, a commit marker, or an enumerated list marker in an added comment — so it needs no model and gates this repository's own CI with --strict. Questions now batch over one copy of the state, which is where the saving comes from when the state is a diff.
6 tasks done
Contributor
Author
|
Closing unmerged. The ranking half overlaps local semantic search, which already indexes the invariants and returns the same pages at section granularity for free; the discovery reading-order step is better served there. The comment-hygiene half is exact and cheap and may return on its own if the rule proves worth enforcing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two checks that run unattended, with no agent driving them.
Knowledge drift ranking (
tools/check_knowledge_drift.py). Judges every invariant against a change and lists the pages documenting the affected ones, so the PR rule inmaintenance/freshness.md— update affected knowledge, link a focused follow-up, or state why it is unaffected — arrives as a checklist. It reads a pull request (--pr), a local checkout (--repo), a diff on stdin, or an issue (--text).--pagesalso ranks the pages no invariant cites: 27 of 75 substantive pages are cited by an invariant, sobuilders/,learning/,examples/andconformance/are otherwise unreachable.--jsonand--topserve a calling agent.Questions batch over one copy of the state, so 56 invariants ride in 3 requests rather than 56. The change dominates each request, which is where the saving comes from.
Comment hygiene (
tools/check_comment_hygiene.py).AGENTS.mdpermits exactly one process reference in a code comment: an invariant ID. This finds the others in added comment lines — a URL, an issue reference, a severity label, a packet reference, a commit or milestone marker, an enumerated list marker. Every rule is exact, so it uses no model, needs no key, and needs no calibration. It gates this repository's CI with--strict.It found two false positives in its own first run:
--intentand--questionsin a usage example read as SQL--comments. Fixed by requiring the space, with tests both ways. An exact rule fails visibly; a threshold does not.CI: the existing job now runs every
tools/test_*.pyrather than one, and adds the comment check on pull requests.Source / provenance checklist
spec-revieweddate changed.upstream-baselineorrevieweddate changed.Behavior-change checklist
Not applicable. No engine behaviour changes, and no invariant statement is edited.
Drift
TYPESAFE_API_KEY; without it every tool prints a skip line and exits 0, as on fork pull requests.