Repository navigation
Fixes and new enhancements - #3290
Conversation
MichaelDvP
left a comment
There was a problem hiding this comment.
For customizing min/max and reset to default it only works after new start. We do not save the the original setting from register_value, so last modification stay.
Store the original min/max for every entity needs a lot of extra mem, not worth for a customization of very few values.
MichaelDvP
left a comment
There was a problem hiding this comment.
111 files changed, 3823 lines added, mostly empty lines, but hard to find the real changes in code.
But i think all is ok.
For the min/max rest we need to change the logic. Keep dv.min/dv.max unchanged (remove call of set_custom_minmax()) in devicevalue constructor and only set the custom values in dv.get_min_max()
yes, lots of small incremental changes. The big ones are:
|
|
Custom min/max are now applied only when the limits are read. dv.min and dv.max stay as the register values, so a reset can restore them without a restart and without storing a second copy. |
MichaelDvP
left a comment
There was a problem hiding this comment.
min, max works, but i have found that a device custom name is cleared when editing and save a entity.
Ah, yes. That would explain why some users saw their custom name for a device disappearing after a restart. The bug was in the customization_entities() where the whole record was re-created and custom_name and custom_brnd were missing. fixed now. |
fixes for #3283 #3280 #3258 and #3097 and #3094