Skip to content

Fixes and new enhancements - #3290

Merged
proddy merged 51 commits into
emsesp:devfrom
proddy:dev
Oct 20, 2026
Merged

proddy merged 51 commits into
emsesp:devfrom
proddy:dev

Conversation

@proddy

@proddy proddy commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

fixes for #3283 #3280 #3258 and #3097 and #3094

@MichaelDvP MichaelDvP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For customizing min/max and reset to default it only works after new start. We do not save the the original setting from register_value, so last modification stay.
Store the original min/max for every entity needs a lot of extra mem, not worth for a customization of very few values.

Comment thread interface/src/app/main/CustomizationsDialog.tsx
Comment thread interface/src/app/main/CustomizationsDialog.tsx
Comment thread src/uart/emsuart_esp32.cpp
@proddy
proddy marked this pull request as ready for review October 15, 2026 20:15

@MichaelDvP MichaelDvP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

111 files changed, 3823 lines added, mostly empty lines, but hard to find the real changes in code.
But i think all is ok.
For the min/max rest we need to change the logic. Keep dv.min/dv.max unchanged (remove call of set_custom_minmax()) in devicevalue constructor and only set the custom values in dv.get_min_max()

@proddy

proddy commented Oct 17, 2026

Copy link
Copy Markdown
Contributor Author

111 files changed, 3823 lines added, mostly empty lines, but hard to find the real changes in code. But i think all is ok. For the min/max rest we need to change the logic. Keep dv.min/dv.max unchanged (remove call of set_custom_minmax()) in devicevalue constructor and only set the custom values in dv.get_min_max()

yes, lots of small incremental changes. The big ones are:

  1. the introduction of "platform_packages = framework-arduinoespressif32 @ https://github.com/emsesp/esp32-arduino-lib-builder/releases/download/1410-0850-5.5.5/framework-arduinoespressif32-v5.5.5-a63b839f.tar.xz"
  2. The auto-reply in EMSESP::reply_own_request() - that's one if you wouldn't mine looking at
  3. The code hopefully fixing the KR30/UI800 issue in No communication via EMS BUS connection after K30RF upgrade - error 1010 #3094, which is hidden behind a DEFINE called EMSESP_GATEWAY_TX_HOLD, and not activated
  4. the min/max - I'll apply the custom min and max inside get_min_max() instead, as it does save memory

@proddy

proddy commented Oct 17, 2026

Copy link
Copy Markdown
Contributor Author

Custom min/max are now applied only when the limits are read. dv.min and dv.max stay as the register values, so a reset can restore them without a restart and without storing a second copy.

@proddy
proddy requested a review from MichaelDvP October 17, 2026 11:48

@MichaelDvP MichaelDvP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

min, max works, but i have found that a device custom name is cleared when editing and save a entity.

@proddy

proddy commented Oct 17, 2026

Copy link
Copy Markdown
Contributor Author

min, max works, but i have found that a device custom name is cleared when editing and save a entity.

Ah, yes. That would explain why some users saw their custom name for a device disappearing after a restart. The bug was in the customization_entities() where the whole record was re-created and custom_name and custom_brnd were missing. fixed now.

@proddy
proddy merged commit 2a72d48 into emsesp:dev Oct 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants