feat(songs): responsive chart data and optional Rust replay controls - #11
Merged
Merged
Conversation
nichinichisou0609
marked this pull request as draft
September 29, 2026 19:13
Contributor
Author
|
Paused: whether the per-chart best formation goes into the song data is being reconsidered (maybe a per-skill aptitude table instead). The formation parts (the five slots, the gs setting, gekisouPair, formationSlots, the guide's paragraph on the search) wait for that decision; the rest (data detection and fallbacks, rangeMeasures, the guide's general Gekisou skill mechanics, the test fixtures) does not depend on it. Draft until then. |
…sou range Each Gekisou range ranks the room by its mission's measure (combo: max combo, luck: luck points, Just: Just count). The detail lists the three measures per range (seed means, min–max) with the compared one marked, in Gekisou Live; a measure older data lacks shows as "–". ranking.js rangeMeasures, MISSION_MEASURE, MEASURES; catalog.js gekisouSkill looks up Gekisou skill names in gekisouCatalog with fallbacks, for the aptitude table to come.
A section on the Gekisou skills: battleLiveScore only, mission-gated, the band condition of support skills, what stays exact and what is approximate with them, the skills that do nothing in the theoretical best play or only raise a rank measure, the seed mean, and the state of the checks (audited, native whole-live comparison under way). The page's figures are without Gekisou skills; the aptitude data is pending.
nichinichisou0609
force-pushed
the
feat/songs-gekisou-skills
branch
from
September 29, 2026 19:23
e71d6ba to
486ed40
Compare
… conversion Keep baseline scores unchanged. Compute aptitude rank and accuracy changes, withhold complete gains below full Just when ordinary skills need unmeasured Perfect cross weights, and expose SE only for original sampled statistics. Add catalog shape names and synthetic tests. Master integer effect values use float32 conversion; user percentages do not. Co-Authored-By: Claude Code <noreply@anthropic.com>
List single-skill variants, equivalent skill names, band conditions, score gains, raw sampling errors and range-measure changes. Keep baseline rankings unchanged. Explain non-additivity, measurement hosts, sampling and missing Perfect cross weights in both languages. Update only numeric cells during slider changes. Co-Authored-By: Claude Code <noreply@anthropic.com>
nichinichisou0609
changed the title
Remove the unverified implication from increased Just counters to support score gains. Keep combo saturation, luck-rush interaction and judgement conversion as non-additivity examples without generalizing the isolated no-interaction result. Co-Authored-By: Claude Code <noreply@anthropic.com>
Add visible Beta badges next to the page and aptitude headings, linked to Chinese/English descriptions through aria-describedby. State that figures may change, luck results have sampling error and native whole-live checks are incomplete. Reuse existing theme tokens without adding feedback links. Co-Authored-By: Claude Code <noreply@anthropic.com>
Contributor
Author
|
已追加 Beta 标识：页标题及激走技能适性章节均显示 Beta，并以 aria-describedby 关联可见中英说明（测试中、数值可能调整、幸运采样误差、原生整局核对未完成）。沿用现有主题，无反馈链接。npm test 565 项、typecheck、build --check 及无浏览器 DOM 交互检查通过。尚未合并或部署。 |
Record chart 10000201 at power 300000 with no skills and Gekisou off: 364 Perfect inputs match by note ID, time and frame; final score 1063422 matches deck. Limit the evidence to this input and final score, with per-frame scoring, skills and Gekisou still unchecked and Unity/external dependency substitutes still present. Keep Beta. Co-Authored-By: Claude Code <noreply@anthropic.com>
Keep aligned responsive tables, a Pareto frontier and one detailed tooltip. Restore lookup-based accuracy estimates and update rankings after dragging. Place common chart facts first and Gekisou aptitude last. Share the optional Rust replay editor with per-segment probabilities and reproducible inputs. Co-Authored-By: Claude Code <noreply@anthropic.com>
nichinichisou0609
changed the title
nichinichisou0609
marked this pull request as ready for review
September 30, 2026 06:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chart-data page now keeps comparison columns aligned across screen sizes, draws a Pareto frontier and shows one detailed scatter tooltip. Accuracy controls use the existing lookup/interpolation model and update results when dragging ends, avoiding repeated full-table work.
Common chart facts, timeline, weights and rank thresholds come first; single-skill Gekisou aptitude is last. An optional shared editor generates reproducible per-segment judgement probabilities for the Rust/WASM engine. Individual notes and JSON inputs remain advanced controls. MoeNotes uses site language/theme and site-hosted covers.
Validation: CI passes on Node 22, 24 and 26, including unit tests, type checks and builds. Browser checks cover restored accuracy controls, per-note Rust results, aligned tables and the single tooltip. Rust owns scoring; ranking estimates remain explicitly marked, and aptitude is not added to baseline rankings or combined into a formation.
🤖 Generated with Claude Code