docs(examples): chart data guide: where the figures come from - #10
Merged
Merged
Conversation
… against the game's code
nichinichisou0609
force-pushed
the
docs/songs-guide-provenance
branch
from
September 29, 2026 17:26
1eb9994 to
46d273e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chart data page guide now says plainly that the figures are computed by ournotes-deck, a rewrite after the decompiled client code, and that the game's own functions only check the rewrite piece by piece in an ARM64 emulator; no whole live has been run with the game's code or checked against real plays.
Only examples/songs/text.js (zh and en) changes. npm test 557 pass, typecheck and build --check pass.