ci: pin the ruff rule set - #6
Merged
nichinichisou0609 merged 1 commit intoAug 29, 2026
Merged
Conversation
The workflow installs ruff unpinned and `ruff check` ran with whatever rule set that version defaulted to. A newer ruff widened the default, so CI started reporting 184 findings across code that had not changed, and the test job failed before pytest ever ran. Select ruff's documented defaults explicitly. No source changes are required: the tree is already clean under this rule set. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow installs ruff unpinned, so
ruff check python testsran withwhatever rule set that version defaulted to. A newer ruff widened the default
and CI began reporting 184 findings across code that had not changed — the
testjob now fails before pytest ever runs, on every branch includingmain.Select ruff's documented defaults (
E4,E7,E9,F) explicitly. Nosource changes are required: the tree is already clean under this rule set, so
this restores a green
testjob and makes the lint result reproducible acrossruff upgrades.
Widening the rule set later is then a deliberate change with its own diff,
rather than something an upgrade does silently.