Repository navigation
Rules: Search the IPTC Content fields in Any Searchable Text - #778
Merged
Merged
Conversation
Headline, category, other categories and subject codes are text a person would expect the rule to find, like the title and caption it already searches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #754, for #687. Any Searchable Text now also looks through Headline, Category, Other Categories and IPTC Subject Code, so a smart collection can find a photo by any of them.
I left Description Writer out, since it names who wrote the text and creator isn't searched either. The Library filter's text search is unchanged. It skips city, state and country today too, so I'd treat that as its own question.
The new test fails without the change. The lcc-catalog tests pass and fmt, clippy, layers and notes are clean. The wasm check couldn't run here because the wasm32 target isn't working on this machine.
Let me know if you'd rather fix it another way. Thank you.