Migrate to warp-drive legacy mode - #173
Open
tcjr wants to merge 4 commits into
Open
Conversation
✅ Deploy Preview for upgrade-guide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates this app from EmberData to WarpDrive (LegacyMode).
I followed the process as detailed in the wonderful blog post about migrating Super Rentals.
I took the approach of getting the frontend code to adapt to the existing JSON files as they are currently created by the
lib/content-generatoraddon rather than change that addon to create different JSON. I adhered to the WarpDrive rules on consistency for the legacy model files.