Skip to content

Use customizable select for version pickers #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mansona merged 2 commits into from
Jun 26, 2026
Merged

Use customizable select for version pickers #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a4a399
Use customizable select for version pickers
tcjr Jun 10, 2026
f7d998d
add minor style tweaks
mansona Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/components/ember-versions-form.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<form
class="ember-versions-form"
data-test-form="Ember Versions"
{{on "submit" this.submitForm}}
>
Expand All @@ -12,6 +13,7 @@
>
{{#each this.groupedVersions as |versionGroup|}}
<optgroup label={{concat "v" versionGroup.major ".x"}}>
<legend>{{versionGroup.major}}.x Versions</legend>
{{#each versionGroup.versions as |version|}}
<option
selected={{eq version this.fromVersion}}
Expand All @@ -35,6 +37,7 @@
>
{{#each this.groupedVersions as |versionGroup|}}
<optgroup label={{concat "v" versionGroup.major ".x"}}>
<legend>{{versionGroup.major}}.x Versions</legend>
{{#each versionGroup.versions as |version|}}
<option
selected={{eq version this.toVersion}}
Expand Down
2 changes: 2 additions & 0 deletions app/styles/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
/* Ember supports plain CSS out of the box. More info: https://cli.emberjs.com/release/advanced-use/stylesheets/ */

@import url("./ember-versions-form.css");

/*
This project is using an old version of the styleguide, so these highly-targeted rules are a bridge
to meet accessibility guidelines until we upgrade to a compliant styleguide.
Expand Down
72 changes: 72 additions & 0 deletions app/styles/ember-versions-form.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
.ember-versions-form {
/* Fallback styling for older browsers */
select {
appearance: auto;
}

/* Progressive enhancement for modern browsers */
@supports (appearance: base-select) {
select {
appearance: base-select;
}

/* stylelint-disable selector-pseudo-element-no-unknown */
select::picker(select) {
appearance: base-select;
background-color: var(--color-gray-100);
margin-right: var(--spacing-6);
margin-bottom: var(--spacing-1);
border-radius: var(--radius);
}

select::picker-icon {
transition: 150ms ease;
}

/* stylelint-disable selector-pseudo-class-no-unknown */
select:open::picker-icon {
rotate: 180deg;
}

select optgroup {
display: flex;
flex-flow: row wrap;
gap: 0.5rem;
padding: 0.5rem;
}

select optgroup legend {
width: 100%;
}

select option {
background-color: var(--color-button-secondary-bg);
color: var(--color-button-secondary-text);

&:hover {
background-color: var(--color-button-secondary-bg-hover);
color: var(--color-button-secondary-text-hover);
}

display: inline-block;
padding: 0.25rem;
border-radius: 0.25rem;
align-content: center;
cursor: pointer;
}

select option::checkmark {
display: none;
}

select option:checked {
background-color: var(--color-button-bg);
color: var(--color-white);
}

select option:checked::checkmark {
display: inline-block;
color: var(--color-button-text);
}
}
}
Loading