Skip to content

Pin the reviewed Feedz publish policy - #9129

Merged
sfmskywalker merged 1 commit into
mainfrom
chore/pin-feedz-operational-policy
Oct 30, 2026
Merged

sfmskywalker merged 1 commit into
mainfrom
chore/pin-feedz-operational-policy

Conversation

@elsa-workflows-bot

@elsa-workflows-bot elsa-workflows-bot Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Signed off by the accountable owner (see comment); ready to merge.

This pins REVIEWED_OPERATIONAL_POLICY in scripts/integration-program/consolidated_package_executor.py (it was None, so admission always stopped at operational_policy_unconfigured). It also adds the decision record that the policy hashes.

Pinned values

Read from the GitHub API (environments/feedz-publish and its deployment-branch-policies) at 2026-10-30T02:12:00Z:

Key Value
environment_id 25739609238
reviewer_rule_id 70613239
branch_rule_id 70613240
reviewer_ids [938393] (sfmskywalker)
branch_policies [{"id": 64850643, "type": "branch", "name": "main"}]
allowed_ref refs/heads/main
operational_packet_sha256 416725fcd31207336a3fd9bd0d4eb18d2ff618ddcda9fb137dcc5b1d87f49d17

Operational packet

docs/integration-program/feedz-publish-operational-packet.md records the decision: publish the pinned 3.10.0 consolidated candidate (source 5cff6722, run 40347931480, artifact 12664519771) to Feedz elsa-3 through feedz-publish. It also names the roles (dispatcher elsa-workflows-bot, sole approver and accountable owner sfmskywalker), the environment identity, and the status, which is "pending approval". The SHA-256 above covers the file's exact bytes, so any edit to the packet also needs this hash updated.

Any change to the feedz-publish environment, including deleting and recreating it, changes these ids. Admission then fails closed until a new PR pins the new values.

Tests

  • Tests that cover a missing policy now patch it to None.
  • A new test checks that the pinned policy passes shape validation and that its hash matches the packet file.
  • python3 -m unittest discover -s scripts/integration-program -p 'test_consolidated*.py' (also with -O): 164 tests OK.
  • scripts/test_validate_packages_workflow_gates.py, test_validate_packages_id_set.py, test_validate_packages_publication_selection.py, test_stage_consolidated_candidate_nupkgs.py: OK.

Pin the feedz-publish environment identity and the SHA-256 of a new
operational packet in REVIEWED_OPERATIONAL_POLICY. Tests that cover a
missing policy now patch it to None, and a new test checks that the
pinned policy passes shape validation and matches the packet bytes.
@elsa-workflows-bot elsa-workflows-bot Bot added this to the 3.10 milestone Oct 30, 2026
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5c380814-ba8a-458b-aa20-99f1e86da721

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@elsa-3-lead

elsa-3-lead Bot commented Oct 30, 2026

Copy link
Copy Markdown

[Elsa 3 Lead] On behalf of @sfmskywalker.

I sign off on the Feedz publish operational packet in this PR as written (docs/integration-program/feedz-publish-operational-packet.md, sha256 416725fcd31207336a3fd9bd0d4eb18d2ff618ddcda9fb137dcc5b1d87f49d17 at head 742f2cd). Scope: Feedz only, dispatched by elsa-workflows-bot, approved by me in the feedz-publish environment.

@elsa-workflows-bot review

@elsa-3-lead
elsa-3-lead Bot marked this pull request as ready for review October 30, 2026 03:13
@greptile-apps

greptile-apps Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

This PR does not match any of the 1 configured review trigger rule.

@elsa-workflows-review-bot elsa-workflows-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elsa 3 Code Review: APPROVE + HIGH @ 742f2cd

Code Review, Round 1/6

Small, focused change: it replaces the None placeholder in REVIEWED_OPERATIONAL_POLICY with concrete values, adds the decision record those values hash, and adjusts the tests that relied on the placeholder. No blocking findings.

Verified

  • Policy pins match the live environment. Read-only reads of environments/feedz-publish and its deployment-branch-policies at review time return env id 25739609238, can_admins_bypass: false, required reviewers rule 70613239 (reviewer 938393, prevent_self_review: true), branch policy rule 70613240, deployment_branch_policy = custom policies only, and exactly one branch policy {"id": 64850643, "type": "branch", "name": "main"}. Every pinned value agrees, and so does each runtime condition in check_admission (two rules, reviewer set, branch policy list equality, allowed_ref = refs/heads/main).
  • Packet hash matches. sha256 of the exact bytes of docs/integration-program/feedz-publish-operational-packet.md at this head is 416725fcd31207336a3fd9bd0d4eb18d2ff618ddcda9fb137dcc5b1d87f49d17, identical to the pinned operational_packet_sha256, computed the same way the new test does (hashlib.sha256(path.read_bytes())).
  • Admin bypass stays required off. check_admission still requires environment.get("can_admins_bypass") is False before any rule checks; nothing in this PR touches that path or the workflow.
  • Drift fails closed. The hash link is enforced by the new unit test, and the publish workflow's verify job runs test_consolidated_package_executor (normal and -O) at the same SHA before admit can run. An edit to the packet without a matching hash update therefore stops a publish run before admission.
  • Tests. Locally at this head: test_consolidated_package_executor 53 OK (also with -O), test_consolidated*.py discovery 164 OK, and the four scripts/test_* package/stage suites 90 passed. Mutation checks: appending one byte to the packet fails the new test, and making a pinned id a string fails it with operational_policy_invalid. The two existing tests that covered the missing policy now patch it to None explicitly, so they keep testing the same thing.
  • CI. All check runs on this head are green.

Non-blocking

  1. The new test name says "passes shape validation". It reaches runtime_not_admitted, which proves the type/shape block passes, but the allowed_ref and branch_policies consistency checks run later in check_admission and are not exercised for the pinned values here. A follow-up could split those consistency rules into a small pure helper and assert them directly against the pinned policy. Not needed for this PR.
  2. The PR description still opens with the draft notice ("awaiting sign-off ... Do not merge"). The sign-off is now recorded in the PR conversation, so refreshing the description before merge keeps the history clear.
  3. The packet's Status section reads "Pending approval". Its own wording (takes effect after sign-off and merge) stays accurate after merge, and changing it would change the pinned hash, so leaving it as is is reasonable.

No review threads are open; CodeRabbit skipped (bot author) and Greptile did not trigger.

— Code Review (Elsa 3), via Elsa Review

@sfmskywalker
sfmskywalker merged commit 8b57fc3 into main Oct 30, 2026
21 of 22 checks passed
@sfmskywalker
sfmskywalker deleted the chore/pin-feedz-operational-policy branch October 30, 2026 03:18
@dotnet-policy-service

Copy link
Copy Markdown

@elsa-workflows-bot[bot] please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ),
and conveys certain license rights to the .NET Foundation ( “.NET Foundation” ) for Your contributions to
.NET Foundation open source projects. This Agreement is effective as of the latest signature date below.

1. Definitions.

“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to .NET Foundation under this Agreement.

“Project” means any of the projects owned or managed by .NET Foundation and offered under a license
approved by the Open Source Initiative (www.opensource.org).

“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”

“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.

2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.

3. Originality of Work. You represent that each of Your Submissions is entirely Your
original work. Should You wish to Submit materials that are not Your original work,
You may Submit them separately to the Project if You (a) retain all copyright and
license information that was in the materials as you received them, (b) in the
description accompanying your Submission, include the phrase "Submission
containing materials of a third party:" followed by the names of the third party and any
licenses or other restrictions of which You are aware, and (c) follow any other
instructions in the Project's written guidelines concerning Submissions.

4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.

5. Licenses.

a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly
or indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable
license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform,
and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing
rights to third parties.

b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or
indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license
under Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.

c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

6. Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3 ). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6 , THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.

7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or
circumstances of which You later become aware that would make Your representations in this
Agreement inaccurate in any respect.

8. Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.

9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.

10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by .NET Foundation.

.NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant