Repository navigation
[3.10] Dependency bumps - #9123
sfmskywalker wants to merge 3 commits into
Conversation
* chore(deps): bump WebAssembly.Server to 10.0.13 Move remaining Microsoft.AspNetCore.Components.WebAssembly.Server 10.x pins to the first patched version for GHSA-qjpx-jqm5-h2c4. Template host references were already updated in #8880. Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com> * chore(deps): pin WebAssembly.Server to first patched 8.x/9.x/10.x versions Bump remaining 8.x and 9.x Server pins, introduce WebAssemblyServerPatchedVersion in apps, and comment why Server patch versions differ from sibling WebAssembly packages. Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> (cherry picked from commit c3c6216)
Update root Directory.Packages.props to AutoMapper 16.1.1, MailKit 4.16.0, and NuGet.Protocol 7.0.3 for the 3.10.1 patch line. Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
|
@elsa-workflows-bot review |
[Medium impact] The package updates reach dependency resolution across Elsa projects, apps, and Studio. The central package requirement must be satisfied before merging: the .NET 8 package overrides in Findings
Fix with agent prompt### Issue 1
extensions/src/dropins/Elsa.DropIns/Elsa.DropIns.csproj:17
`Elsa.DropIns.csproj` now hard-codes .NET 8 versions for `System.Security.Cryptography.Pkcs` here and `System.Formats.Asn1` on line 20. The repository guide requires versions in `Directory.Packages.props` unless project-level versions already exist for that package; neither package had that pattern. These overrides bypass subsequent central version updates for the .NET 8 build. Move these exceptions into central package settings before merging to satisfy the repository requirement.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.SummaryUpdates package pins for the 3.10.1 release.
The full solution build and listed test suites have not been verified. Reviews (2) · Last reviewed commit: "Pin transitive crypto package to patched..." · Reviewed by Greptile |
Add per-TFM PackageVersion pins and explicit PackageReferences so the patched System.Security.Cryptography.Pkcs versions flow to consumers as direct package dependencies. Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com>
There was a problem hiding this comment.
Elsa 3 Code Review: APPROVE + HIGH @ 1ae581a
Code Review, Round 1/6
These are dependency bumps for the 3.10.1 line on release/3.10.0, in three commits, none of which changes code. All three are clean.
Cherry-pick of #9004 (b3876d7)
git range-diffagainstc3c62163shows an identical patch. The only addition is the(cherry picked from commit ...)trailer.- Every
Microsoft.AspNetCore.Components.WebAssembly.Serverpin and reference resolves to 8.0.32, 9.0.21 or 10.0.13 in the root,apps/,extensions/src/,studio/src/and the template hosts. No older version remains in any restoredproject.assets.json.
Root pin bumps (2c15eea)
| Package | Before | After |
|---|---|---|
| AutoMapper | 16.0.0 | 16.1.1 |
| MailKit | 4.14.1 | 4.16.0 |
| NuGet.Protocol | 7.0.1 | 7.0.3 |
None of these crosses a major version, and none changes a resolved package on this branch:
- No project references AutoMapper.
- MailKit and NuGet.Protocol are consumed only by
Elsa.EmailandElsa.DropIns, which take their versions fromextensions/src/Directory.Packages.props. That file already pins 4.16.0 and 7.0.3.
The bumps only keep the root file in line with the extensions scope.
Transitive crypto pin (1ae581a)
git range-diffagainst #9124 @c12a87b2shows the patches are identical (1: c12a87b2c = 1: 1ae581a42), and the same 19 projects change.- I ran
dotnet pack -c Releaseon this head for all 19 projects. Every.nuspeclistsPkcsdirectly in each TFM group, with the same versions as onmain:- 18 packages: 8.0.2 / 9.0.21 / 10.0.13 (net8.0 / net9.0 / net10.0).
Elsa.DropIns: 9.0.21 on net8.0 (withSystem.Formats.Asn19.0.21), 9.0.21 on net9.0, 10.0.13 on net10.0.
- In
project.assets.json, the 19 projects resolve exactly those versions, with no NU1605/NU1608 or other restore warnings. Their full resolved package sets are identical to the #9124 head, so the two branches stay in step. - The
Elsa.DropInsnet8.0VersionOverrideis the smallest way to express what NuGet.Packaging 7.0.3 requires there (Pkcs>= 9.0.6). I'm fine keeping it local, as on #9124.
Non-blocking
- Same notes as #9124: a one-line comment on the
Elsa.DropInsoverride would keep later bumps in step, and thenetstandardentries are unused. - The root AutoMapper, MailKit and NuGet.Protocol pins are unused (from
2c15eea5).mainremoves them in #9122. If that cleanup is ever picked onto 3.10, these lines will conflict trivially.
Bot threads
- Greptile P2 (
Elsa.DropIns.csproj:17, project-level versions): replied on the thread. No action needed, for the same reasons as on #9124. Resolved. - CodeRabbit skipped this PR (non-default base branch).
CI
All checks on this head are green. This is approve-only: it targets a release branch and merges after 3.10.0 is tagged.
— Code Review (Elsa 3), via Elsa Review
Purpose
Dependency bumps for 3.10.1.
Scope
Select one primary concern:
Description
Problem
Patch-line package pins on
release/3.10.0need the 3.10.1 dependency updates.Solution
This PR carries main commit
c3c621636718390d915de2573e03b42f51339dcb(#9004) viagit cherry-pick -x, plus the root pin bumps.build/_build.csprojalready has theSystem.Security.Cryptography.Xml10.0.13 pin in the same form as main.Packages and versions:
Microsoft.AspNetCore.Components.WebAssembly.Server: 8.0.32 / 9.0.21 / 10.0.13 (matching major)AutoMapper: 16.0.0 -> 16.1.1MailKit: 4.14.1 -> 4.16.0NuGet.Protocol: 7.0.1 -> 7.0.3System.Security.Cryptography.Xml: 10.0.13 (already pinned on this branch)System.Security.Cryptography.Pkcs: 8.0.2 (net8), 9.0.21 (net9), 10.0.13 (net10), added as a direct package dependency on the projects that already close over it. Elsa.DropIns net8 uses 9.0.21 because NuGet.Packaging 7.0.3 requires a 9.x line.No API changes.
Verification
Steps:
Elsa.sln.build/_build.csproj,Elsa.Email,Elsa.DropIns, and the WebAssembly.Server hosts.Elsa.Workflows.Core.UnitTests,Elsa.Common.UnitTests,Elsa.Http.UnitTests, andElsa.Studio.Core.Tests.System.Security.Cryptography.Pkcsis a direct nuspec dependency at the per-TFM versions above.Expected outcome: restore, build, and the listed unit tests succeed.
Commit Convention
chore(deps)for the root pins.Checklist