Skip to content

Make authenticated container smoke checks compatible with Elsa 3.8.4 - #11

Merged
sfmskywalker merged 2 commits into
mainfrom
codex/container-api-smoke-compatibility
Oct 8, 2026
Merged

sfmskywalker merged 2 commits into
mainfrom
codex/container-api-smoke-compatibility

Conversation

@sfmskywalker

Copy link
Copy Markdown
Member

The 3.8.4 backfill failed because its server has no /identity/me/permissions endpoint. Combined hosts can return their HTML fallback for that missing route, so checking HTTP 200 alone could also accept an invalid authenticated API probe.

Use bearer-authenticated GET /elsa/api/workflow-definitions?page=0&pageSize=1, which is permission-protected in both 3.8.4 and 3.9.0, and require a paged JSON response. Include the failed endpoint, image and platform in timeout diagnostics while preserving the existing timeout and publication gates.

Validation: 25 policy tests pass, including authorization-header propagation, HTML and invalid-JSON-schema rejection, and timeout context. The updated helper and independent API harness pass against the actual local 3.8.4 Docker host. This fixes the backfill failure observed in run 37736451732; it does not modify application packages or existing image tags. Follow-up to #10.

@sfmskywalker

Copy link
Copy Markdown
Member Author

@greptileai

@sfmskywalker

Copy link
Copy Markdown
Member Author

Independent review: APPROVE at 1f895ac0e02a871f1610f977484ae45cd6adaa73.

Verified the permission-protected workflow definitions route and paged response at both Core 3.8.4 and 3.9.0. The new JSON assertions reject an HTML fallback response. Timeout errors retain endpoint, image and platform context without changing the timeout or logging credentials.

All 25 focused Python tests pass normally and under python3 -O. All six image build and smoke jobs passed on this head. No blocking findings.

@greptile-apps

greptile-apps Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium risk] Updates container release smoke check to use a different API endpoint.

No outstanding findings block merging these changes.

Summary

This PR switches the authenticated container check to /elsa/api/workflow-definitions?page=0&pageSize=1 and requires a paged JSON response. Failed checks now include the endpoint, image, and platform in their errors. The latest change addresses the previous credential-test finding by checking that the actual generated password and username are absent from the error. No new actionable issues were found.

Reviews (2) · Last reviewed commit: "Assert actual smoke credentials are abse..." · Reviewed by Greptile

Comment thread scripts/tests/test_container_release.py Outdated
@sfmskywalker

Copy link
Copy Markdown
Member Author

@greptileai

@sfmskywalker

Copy link
Copy Markdown
Member Author

Independent follow-up review: APPROVE at full current HEAD 8ced578. Reviewed the credential assertion change; both credential tests pass normally and under python3 -O. No blocking findings.

@sfmskywalker
sfmskywalker merged commit dbf2a2d into main Oct 8, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant