Repository navigation
Make authenticated container smoke checks compatible with Elsa 3.8.4 - #11
Conversation
|
Independent review: APPROVE at Verified the permission-protected workflow definitions route and paged response at both Core 3.8.4 and 3.9.0. The new JSON assertions reject an HTML fallback response. Timeout errors retain endpoint, image and platform context without changing the timeout or logging credentials. All 25 focused Python tests pass normally and under |
|
|
Independent follow-up review: APPROVE at full current HEAD 8ced578. Reviewed the credential assertion change; both credential tests pass normally and under python3 -O. No blocking findings. |
The 3.8.4 backfill failed because its server has no
/identity/me/permissionsendpoint. Combined hosts can return their HTML fallback for that missing route, so checking HTTP 200 alone could also accept an invalid authenticated API probe.Use bearer-authenticated
GET /elsa/api/workflow-definitions?page=0&pageSize=1, which is permission-protected in both 3.8.4 and 3.9.0, and require a paged JSON response. Include the failed endpoint, image and platform in timeout diagnostics while preserving the existing timeout and publication gates.Validation: 25 policy tests pass, including authorization-header propagation, HTML and invalid-JSON-schema rejection, and timeout context. The updated helper and independent API harness pass against the actual local 3.8.4 Docker host. This fixes the backfill failure observed in run 37736451732; it does not modify application packages or existing image tags. Follow-up to #10.