Skip to content

fix(tools): show eval output and finish detached eval cards - #14

Closed
e-n-0 wants to merge 1 commit into
mainfrom
flavien.darche/detached-eval-cards
Closed

e-n-0 wants to merge 1 commit into
mainfrom
flavien.darche/detached-eval-cards

Conversation

@e-n-0

@e-n-0 e-n-0 commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

What

OmO eval cards now show their output.

  • While a cell runs, the card gets the output tail that OmO streams on tool_execution_update, stored in metadata.output (the field OpenChamber reads for bash).
  • When a cell outlives the foreground window, OmO later sends a hidden senpi-codemode:notification message. Antechamber now finishes the matching card from it: completed with the final output, or an error when the cell was cancelled, failed or was killed. This works live and when history is rebuilt from the session file.

Why

The card used to stop at "Eval cell ... detached and is running", with no printed output and no sign of when the cell finished. The notification has no structured details, so the cell ID and output are parsed from the text format in senpi-codemode's detached-cell-notification.ts.

How to verify

npm run typecheck     # passes
npx tsx --test --import ./test/setup.ts test/detached-eval.test.ts   # 3/3 pass, 3/3 fail without the fix
npm run build         # succeeds
npm run format:check  # clean

I also checked a real OmO session by hand: after a reload, a detached 45-second cell showed its full output ending in done, and a cancelled cell showed as an error. I did not run the full npm test locally, and no smoke script was run. I also haven't confirmed that OpenChamber's generic tool card renders metadata.output while a cell is running.

Checklist

  • npm run typecheck passes
  • npm test passes (only the new test file was run locally)
  • npm run build succeeds
  • New/changed behavior has a test; no fixed sleeps were added
  • Commit messages follow Conventional Commits
  • docs/api-surface.md updated if routes/events changed (n/a)
  • docs/configuration.md updated if an environment variable was added, renamed, or had its default changed (n/a)
  • No personal paths, hostnames, or credentials in the diff

Running eval cards now carry the cell output tail in metadata.output. When OmO settles a detached cell it sends a hidden senpi-codemode:notification; the card that only said "detached and is running" is now completed with the final output, or marked as an error when the cell was cancelled or killed, both live and when history is rebuilt from the session file.
@e-n-0

e-n-0 commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #29 (live eval output on the card) and #31 (detached eval cells finished from their notification). Closing.

@e-n-0 e-n-0 closed this Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant