Repository navigation
Conversation
Running eval cards now carry the cell output tail in metadata.output. When OmO settles a detached cell it sends a hidden senpi-codemode:notification; the card that only said "detached and is running" is now completed with the final output, or marked as an error when the cell was cancelled or killed, both live and when history is rebuilt from the session file.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
OmO
evalcards now show their output.tool_execution_update, stored inmetadata.output(the field OpenChamber reads for bash).senpi-codemode:notificationmessage. Antechamber now finishes the matching card from it: completed with the final output, or an error when the cell was cancelled, failed or was killed. This works live and when history is rebuilt from the session file.Why
The card used to stop at "Eval cell ... detached and is running", with no printed output and no sign of when the cell finished. The notification has no structured details, so the cell ID and output are parsed from the text format in senpi-codemode's
detached-cell-notification.ts.How to verify
I also checked a real OmO session by hand: after a reload, a detached 45-second cell showed its full output ending in
done, and a cancelled cell showed as an error. I did not run the fullnpm testlocally, and no smoke script was run. I also haven't confirmed that OpenChamber's generic tool card rendersmetadata.outputwhile a cell is running.Checklist
npm run typecheckpassesnpm testpasses (only the new test file was run locally)npm run buildsucceedsdocs/api-surface.mdupdated if routes/events changed (n/a)docs/configuration.mdupdated if an environment variable was added, renamed, or had its default changed (n/a)