Repository navigation
Conversation
e-n-0
marked this pull request as ready for review
October 15, 2026 22:35
OpenChamber loads history with limit=50 and follows x-next-cursor via before=. Without the header it treated the newest 50 messages as the whole history, so long sessions whose last page held only assistant replies opened blank.
e-n-0
force-pushed
the
flavien.darche/message-history-paging
branch
from
October 15, 2026 22:43
6c8090d to
fd7c912
Compare
Collaborator
Author
|
already merged on main: close #13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
GET /session/{id}/messagenow acceptsbefore=<messageID>and returns anx-next-cursorheader (the oldest message ID in the page) while older messages remain.Why
OpenChamber loads history with
limit=50and only asks for older pages when it gets anx-next-cursorback. Antechamber never sent one, so the UI took the newest 50 messages as the whole history. In a long session where those 50 are all assistant replies from one turn, there is no user message to group them under, and the session opens blank.How to verify
V124-006 now also checks that the cursor header is set, that
beforereturns the older page, and that the last page has no cursor. I also checked a real 396-message OmO session by hand: paging withlimit=50returned all of it in 8 pages. No smoke script was run.Checklist
npm run typecheckpassesnpm testpasses (session-history file)npm run buildsucceedsdocs/api-surface.mdupdated if routes/events changeddocs/configuration.mdupdated if an environment variable was added, renamed, or had its default changed (n/a)