Repository navigation
Audio: Add noise cancellation and equalization - #248
Draft
Sean-StarLabs wants to merge 7 commits into
Draft
Sean-StarLabs wants to merge 7 commits into
Sean-StarLabs wants to merge 7 commits into
Conversation
This was referenced Oct 3, 2026
Member
|
Hey @Sean-StarLabs just want to confirm you're not using LLMs for this and other branches you've submitted as per our contributor guide? https://docs.elementary.io/contributor-guide/development/generative-ai-policy |
Add a Noise Cancellation option using WebRTC processing for the selected input device. Keep it running after Settings closes, with automatic gain control disabled. Test=Private PulseAudio/PipeWire: on/off, active streams and reconnect.
Add an optional five-band equaliser; the bands are inspired by Realtek's HDA filters. All existing controls remain the same. Use the PipeWire backend and store preferences per output device and route. Test=Private PipeWire: sliders, Reset, recovery and output changes.
Add device profiles to pre-set the EQ. Vendors whose firmware leaves EQ to software can make the speakers sound half decent for the rare few who don't tweak them. Test=Private PipeWire: OEM defaults, neutral routes and rejected profiles.
Attach the filter graph on enable and remove it on disable. Keep saved gains and the physical output unchanged. Test=StarFighter: Off removes the filters, On restores saved gains, and volume, mute and AEC still work.
An empty set of our controls does not mean the graph slot is free.
Check the native graph properties before installing or removing EQ,
including graphs without controls. Leave ALSA device properties alone.
Test=StarFighter: foreign linear and control-less graphs survive EQ
enable/disable; explicit recovery works after removal.
Replace state numbers and positional request fields with names.
Expand the guards so the audit and reconnect paths are easier to follow.
Test=StarFighter: EQ and noise cancellation enable/disable, custom
gains, Reset, mixer controls and audio-server restart.
Stopping removes the queued native audit. Clear its pending flag too, so a disconnected output does not stay busy. Test=Native PipeWire: stopping before the queued audit clears busy; the same check failed before this change.
Sean-StarLabs
force-pushed
the
echo-cancellation-audio
branch
from
October 7, 2026 20:53
59c80f5 to
21122ae
Compare
Sean-StarLabs
changed the title
|
FYI wireplumber devs are planing to drop public GObject API in the next major release https://gitlab.freedesktop.org/pipewire/wireplumber/-/work_items/985 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Noise Cancellation per input and an optional five-band equaliser per output. settings-daemon owns processing, so closing Sound Settings does not switch it off.
EQ stays on the physical output instead of adding another “EQ Speakers” device, as having two volume sliders for one device is chaos. Disabled processing is removed. Device profiles can supply factory defaults; hardware matching stays outside the daemon.
Companion Sound Settings changes: elementary/settings-sound#310
Test=StarFighter MTL: selected-device EQ and Noise Cancellation, audio-server restart, unchanged physical volume/mute/routing, and no extra EQ output. Foreign graphs with and without controls survive enable/disable attempts; removing them permits explicit recovery. Off confirmation waits for graph removal.