Flatpak: Add manifest - #873
TheEvilSkeleton wants to merge 5 commits into
Conversation
|
I will admit, I'm not familiar with Granite. I'm getting these errors: Click to expand
I presume this is being caused by the Flatpak using the runtime's version...? |
|
Could you tell us the reason why you need this? 🤔 |
|
I discussed it with @danirabbit in private, and she let me know that she's been thinking of doing it, so it's nothing that benefits me really :) |
|
@TheEvilSkeleton yeah this is because those widgets, classes, etc are not released yet in stable Granite. Only in main. So the manifest needs to use Granite from main I suppose @ryonakano it's something I talked about previously with William. It would be nice to be able to test against newer GTK features for the new stylesheet etc as we're developing |
hmm, it's weird that the Demo app seems to fail to build despite using |
This comment was marked as outdated.
This comment was marked as outdated.
|
@ryonakano could you mark this pull request as draft? I don't remember how we do that on GitHub... It currently doesn't even build due to meson limitations. Someone offered to add some functionality into meson but we'll have to wait for the next version to be released. |
@leonardo-lemos did that. FYI you can do that under the Reviewers section in the right side of PRs:
@TheEvilSkeleton Could you elaborate on this? What do you mean with "the meson limitations"? And which PR did add the "some functionality" in https://github.com/mesonbuild/meson? |
Thanks!
mesonbuild/meson#14782 - I accidentally mentioned PR rather than "an unpushed commit from someone else's system" 😅 |
013c587 to
98c0bb6
Compare
|
Just to reiterate: at the time of writing this, this PR won't work on the latest stable version of meson; only on mesonbuild/meson#14782. You can install and run that version with: $ pip install git+https://github.com/dcbaker/meson@submit/vala-header-method
$ meson setup --reconfigure _build
$ meson compile -C _build/
$ ./_build/demo/granite-7-demo |
98c0bb6 to
fd0e0f2
Compare
fd0e0f2 to
2156c30
Compare
38bdc66 to
ca6430e
Compare
|
Done |
|
I'm not sure what to do with the CI error. I thought the runtime included a newer version of meson. |
|
The stable and unstable CIs are failing because they build Noble which uses older meson. We're already working for Granite 9 which is API breaking and we won't publish for Noble, I think we can ignore these build failure. |
|
Ah, I misunderstood what you're talking about. It's failing to build with flatpak-builder…… |
|
I could build and run the demo with the following change, although not sure if this is appropriate fix when thinking about the current demo package built with Debian packaging: user@elementary-9-daily:~/work/granite$ git --no-pager diff
diff --git a/demo/GraniteDemo.vala b/demo/GraniteDemo.vala
index cc54a044..3f6c8e92 100644
--- a/demo/GraniteDemo.vala
+++ b/demo/GraniteDemo.vala
@@ -5,7 +5,7 @@
public class Granite.Demo : Gtk.Application {
construct {
- application_id = "io.elementary.granite-9.demo";
+ application_id = "io.elementary.granite.demo";
flags = ApplicationFlags.FLAGS_NONE;
}
diff --git a/demo/build-aux/io.elementary.granite.demo.yaml b/demo/build-aux/io.elementary.granite.demo.yaml
index 8aacdd1b..a57926a4 100644
--- a/demo/build-aux/io.elementary.granite.demo.yaml
+++ b/demo/build-aux/io.elementary.granite.demo.yaml
@@ -2,10 +2,11 @@ id: io.elementary.granite.demo
runtime: io.elementary.Platform
runtime-version: daily
sdk: io.elementary.Sdk
-command: granite-demo
+command: granite-9-demo
tags:
- devel
desktop-file-name-suffix: ' (Development)'
+rename-desktop-file: io.elementary.granite-9.demo.desktop
finish-args:
- --share=ipc
- --socket=fallback-x11
@@ -70,5 +71,5 @@ modules:
buildsystem: meson
sources:
- type: dir
- path: ..
+ path: ../..
user@elementary-9-daily:~/work/granite$ |
This is needed to use the repo's generated library, rather than the system's.
ca6430e to
713fec6
Compare

No description provided.