Skip to content

Fix unmount criticals - #2834

Merged
jeremypw merged 2 commits into
mainfrom
vishal/fix-unmount-criticals
Sep 17, 2026
Merged

jeremypw merged 2 commits into
mainfrom
vishal/fix-unmount-criticals

Conversation

@vjr

@vjr vjr commented Sep 16, 2026

Copy link
Copy Markdown
Member

Fix the following during unmount:

(io.elementary.files:371186): GLib-GObject-CRITICAL **: 23:48:11.625: invalid (NULL) pointer instance

(io.elementary.files:371186): GLib-GObject-CRITICAL **: 23:48:11.625: g_signal_emit_by_name: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed

(io.elementary.files:371186): Gtk-CRITICAL **: 23:48:11.625: gtk_widget_destroy: assertion 'GTK_IS_WIDGET (widget)' failed

@vjr vjr self-assigned this Sep 16, 2026
@vjr
vjr requested review from a team and jeremypw September 16, 2026 18:21

@jeremypw jeremypw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't really need an early return here, you can save a line by testing for dialog != null

@vjr
vjr requested a review from jeremypw September 17, 2026 13:30

@jeremypw jeremypw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jeremypw
jeremypw merged commit a844f2b into main Sep 17, 2026
4 checks passed
@jeremypw
jeremypw deleted the vishal/fix-unmount-criticals branch September 17, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants