Skip to content

Port file delete trash operation to Vala - #2831

Open
jeremypw wants to merge 64 commits into
mainfrom
jeremypw/fileoperations/delete-files-vala
Open

jeremypw wants to merge 64 commits into
mainfrom
jeremypw/fileoperations/delete-files-vala

Conversation

@jeremypw

@jeremypw jeremypw commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #137

Continuing the work of porting remaining C code to Vala.

Also introduces a rudimentary FileOperation Manager to keep track of what jobs are running and in future make this information available to the UI for purposes other than progress indication (e.g. locking the appropriate unmount buttons or providing information to warning dialog).

  • Port permanent delete file
  • Port try trash file
  • Port progress interaction
  • Port undo interaction
  • Port confirm delete (or not) logic
  • Port delete/trash folder
  • Ensure errors and exceptions handled correctly
  • Improve commenting

marlin_file_operations_copy_move_link no longer handles operations with trash:/// as a destination. For the present, testing whether the destination is trash is moved into the calling code when necessary. However, once copy/move/link is ported to Vala (in a future PR) that will not longer be required.

Using async functions for trash and delete fixes some problems with the progress window not appearing.

@jeremypw
jeremypw marked this pull request as ready for review September 25, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No progress indication when trashing many small files after a restoring a large number of files

1 participant