Inconsistent indications of free disk space

[aquierick]

Describe the bug

When selecting on properties for the root directory (the one at the top of the file system where /home is located), the window displays an incorrect value on used disk space and the folder size, however, the information displayed is correct when the data is still loading.

To Reproduce

1. Open 'Files'.
2. In the 'Devices' section, select the file system being used by the OS.
3. Right click in the right part of the window where the directories are displayed.
4. Select 'Properties'

Expected behavior

When the properties window finishes loading I expected to show the data that it already had while loading.

Screenshots or screen recordings

Platform Information

• I'm using the latest version from git that I've manually compiled
• I'm using the latest released stable version

[jeremypw]

What is happening here is that the total space used exceeds the reported volume size so the available space is negative and rolls over to a huge positive number. The cause of this is FIles counting files in folders mounted at e.g. /media which are not necessary on the same volume or even disk. By contrast, Nautilus ignores folders on mounts.

[jeremypw]

On OS8 the device free space info is correct. However the "Size: " label is still far too large when there are mounts. When the location is the root of the filesystem then the "Size" does not really need to be calculated from individual files. It can just be obtained from the filesystem.