WIP - cast GitHub usernames to lowercase#99
Open
mjlshen wants to merge 1 commit intoelekto-dev:mainfrom
Open
Conversation
Signed-off-by: Michael Shen <mishen@umich.edu>
mjlshen
force-pushed
the
case-sensitive
branch
from
0d01cd9 to
c3aa82b
Compare
mjlshen
changed the title
Author
|
I still need to figure out how to test this following https://elekto.dev/docs/setup/devinstall/ |
Member
|
Any luck on testing this? Your code is pretty similar to what I did as a trial earlier, and didn't actually work, due to breaking the URLs. |
Author
|
Sorry, I haven't. I think I'll be able to by the end of next week, but I don't mind if someone beats me to it :D |
Member
|
If you end up putting more code work into this, it would be better to write a utility function that does the case-insensitive list comprehension and make the various references use that. If you get something that functionally works, though, I'll merge it whether or not you did that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to make elekto's voting processes case insensitive with respect to GitHub usernames by casting
eligible_votersand the current user's username to lowercase.Closes #84