Skip to content

Fix GitHub notebook widget publishing and 4D-STEM parity - #240

Merged
bobleesj merged 4 commits into
electronmicroscopy:mainfrom
bobleesj:fix/github-full-widget-output
Aug 26, 2026
Merged

Fix GitHub notebook widget publishing and 4D-STEM parity#240
bobleesj merged 4 commits into
electronmicroscopy:mainfrom
bobleesj:fix/github-full-widget-output

Conversation

@bobleesj

@bobleesj bobleesj commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

What problem does it solve?

GitHub-ready notebooks could render widgets twice or capture folder widgets
before their first complete frame. This keeps one complete UI per cell and
includes the validated Show4DSTEM GPU-parity fixes.

What should reviewer(s) do?

Review the notebook publisher, folder readiness, and Show4DSTEM parity tests.

Verification

  • Python: 1175 passed; frontend: 172 passed.
  • Eleven CUDA drift notebooks passed end to end.
  • 28 widget cells: 28 complete UIs, zero duplicates or saved errors.

This PR follows the
scikit-package workflow for
reproducible scientific software.

@bobleesj
bobleesj merged commit bc35a7a into electronmicroscopy:main Aug 26, 2026
@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
  • Delete bobleesj/quantem.widget:fix/github-full-widget-output from its remote if you own it, it is not long-lived, and no other PR uses it.
  • Remove the dedicated worktree and local fix/github-full-widget-output branch after confirming the worktree is clean.
  • Fetch electronmicroscopy/quantem.widget and update local main before starting new work.

@github-actions

Copy link
Copy Markdown

This PR is 1 commit behind electronmicroscopy/quantem.widget:main.

Fetch that remote and update local main before you branch, or rebase this branch onto it before review.
A warning is enough. The PR can stay open while main moves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant