Skip to content

build(deps-dev): drop tsx in favor of type stripping - #480

Merged
MarshallOfSound merged 1 commit into
mainfrom
build/drop-tsx
Oct 10, 2026
Merged

MarshallOfSound merged 1 commit into
mainfrom
build/drop-tsx

Conversation

@dsanders11

Copy link
Copy Markdown
Member

Lets drop tsx, we can make do without it.

@dsanders11
dsanders11 requested a review from a team as a code owner October 9, 2026 23:34

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — simple, mechanical dev-tooling change.

What was reviewed: the package.json script changes (tsx replaced with node --experimental-strip-types), the five benchmark .ts files' import extension change from ./generate-fixtures.js to ./generate-fixtures.ts (required since Node's type-stripping loader resolves .ts directly), and the yarn.lock diff — confirmed it only removes tsx and its transitive deps (esbuild platform packages, get-tsconfig, resolve-pkg-maps) with no other changes. Also checked the engines field (node >=22.12.0), which supports --experimental-strip-types.

Extended reasoning...

Dev-tooling-only change: benchmark scripts and package.json/yarn.lock, no library or runtime code paths touched, no security-sensitive surface. Change is small, self-contained, and mechanical (swap tsx for Node's native type-stripping flag plus matching import extension updates), with the lockfile diff confirmed to only drop tsx and its transitive dependencies.

@MarshallOfSound
MarshallOfSound enabled auto-merge (squash) October 10, 2026 10:36
@MarshallOfSound
MarshallOfSound merged commit 623d6ad into main Oct 10, 2026
11 checks passed
@MarshallOfSound
MarshallOfSound deleted the build/drop-tsx branch October 10, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants