Fix main-snapshot DRA alias lookup in minor-freeze wait#3071
Merged
Conversation
wait_version_bump_dra.py polled .../latest/main.json for the main
branch's snapshot version during minor-freeze DRA waits. release-manager
names its project-configs dir for main "master", so it only ever
publishes the branch-keyed "latest" snapshot alias as
.../latest/master.json — main.json never gets created, and the wait
times out after 4h instead of resolving once the artifact is published.
Fix by polling the version-keyed "latest" alias
(.../latest/{version}.json) for the main snapshot check instead, since
we already know the expected main version (MAIN_NEW_VERSION) and this
alias is unambiguous regardless of what release-manager calls the main
branch internally.
Observed on the 9.5.0 minor freeze: ml-cpp-version-bump #58 sat waiting
on "main snapshot" even though the underlying main snapshot build
(main-snapshot-builds #6665) had already passed and published
latest/master.json and latest/9.6.0-SNAPSHOT.json with version
9.6.0-SNAPSHOT.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Simpler fix: release-manager's project-configs dir for main is named
"master", so poll the branch-keyed alias it actually publishes
(latest/master.json) directly, rather than the version-keyed
latest/{version}.json alias.
|
Pinging @elastic/ml-core (Team:ML) |
ninalee12
approved these changes
Jul 7, 2026
ninalee12
left a comment
ninalee12
left a comment
Contributor
There was a problem hiding this comment.
Changes here look good to me. Not seeing anything that sticks out.
Verified that URL works as expected:
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
dev-tools/wait_version_bump_dra.py's minor-freeze DRA wait polls.../latest/main.jsonfor the main branch's post-bump snapshot version. That alias never gets created: release-manager'sproject-configsdirectory for main is namedmaster, notmain, so it only ever publishes the "latest" snapshot alias as.../latest/master.json. The wait would run until its 4h timeout and fail instead of resolving once the artifact is actually published.Fix: poll
.../latest/master.jsondirectly for the main-snapshot check instead of the non-existent.../latest/main.json.Observed on the 9.5.0 minor freeze: ml-cpp-version-bump #58 sat waiting on "main snapshot" even though the underlying main snapshot build (main-snapshot-builds #6665) had already passed and published
latest/master.jsonwith version9.6.0-SNAPSHOT.Added a regression test (
test_wait_minor_polls_master_alias_for_main_snapshot) asserting the main-snapshot check pollslatest/master.jsonand never referenceslatest/main.json.Test plan
./dev-tools/run_dev_tools_tests.sh— 60 passed, 2 skipped (unrelated, pre-existing skips)latest/main.json→ 404,latest/master.json→ 200 withversion: "9.6.0-SNAPSHOT"