ci: add team Slack mention to version bump pipeline notifications#3060
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Pinging @elastic/ml-core (Team:ML) |
edsavage
requested changes
Jul 2, 2026
Contributor
There was a problem hiding this comment.
Hi Nina. The sub-team mention name looks correct, but the change would be better placed in .buildkite/pipelines/send_slack_version_bump_notification.sh -- The send_version_bump_notification.sh script is actually orphaned - I've cleaned it up in #3064 (the PR for the minor version bump automation)
2e866f9 to
05b17dd
Compare
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
05b17dd to
85d2156
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an @ml-team Slack subteam mention to the version-bump approval notification posted to #machine-learn-build.
The mention is added in
.buildkite/pipelines/send_slack_version_bump_notification.sh, which runs after the bump steps and notifies the channel when action may be required (e.g. a GitHub PR needs review/approval).This covers both workflows:
Context
Version bump pipelines are triggered centrally by release-eng (unified-release-centralized-version-bump). Previously, notifications in #machine-learn-build did not ping @ml-team, so the team could miss when a bump PR was waiting for approval (e.g. ml-cpp-version-bump #58 (https://buildkite.com/elastic/ml-cpp-version-bump/builds/58) / #3068).
This change targets the active notification script used since #3064 (#3064). It does not modify build blocked/finished notifications — the legacy send_version_bump_notification.sh script was removed in that PR.
Feel free to suggest a different Slack handle or a dedicated person to ping if this isn't the right one for your team.
Test plan
🤖 Generated with Claude Code