Skip to content

ci: add team Slack mention to version bump pipeline notifications#3060

Merged
edsavage merged 1 commit into
mainfrom
update-slack-message
Jul 7, 2026
Merged

ci: add team Slack mention to version bump pipeline notifications#3060
edsavage merged 1 commit into
mainfrom
update-slack-message

Conversation

@ninalee12

@ninalee12 ninalee12 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Add an @ml-team Slack subteam mention to the version-bump approval notification posted to #machine-learn-build.

The mention is added in .buildkite/pipelines/send_slack_version_bump_notification.sh, which runs after the bump steps and notifies the channel when action may be required (e.g. a GitHub PR needs review/approval).

This covers both workflows:

  • Patch (WORKFLOW=patch) — when a version-bump PR is opened
  • Minor feature freeze (WORKFLOW=minor) — when the release branch is created and/or a main-bump PR is opened

Context

Version bump pipelines are triggered centrally by release-eng (unified-release-centralized-version-bump). Previously, notifications in #machine-learn-build did not ping @ml-team, so the team could miss when a bump PR was waiting for approval (e.g. ml-cpp-version-bump #58 (https://buildkite.com/elastic/ml-cpp-version-bump/builds/58) / #3068).

This change targets the active notification script used since #3064 (#3064). It does not modify build blocked/finished notifications — the legacy send_version_bump_notification.sh script was removed in that PR.

Feel free to suggest a different Slack handle or a dedicated person to ping if this isn't the right one for your team.

Test plan

  • Verify Slack notification in the team channel includes the team mention on next version bump run
  • Confirm the mention appears for both patch and minor-freeze notifications when a PR is opened or approval is needed

🤖 Generated with Claude Code

@prodsecmachine

prodsecmachine commented Jun 10, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@elasticsearchmachine

Copy link
Copy Markdown

Pinging @elastic/ml-core (Team:ML)

@edsavage edsavage left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nina. The sub-team mention name looks correct, but the change would be better placed in .buildkite/pipelines/send_slack_version_bump_notification.sh -- The send_version_bump_notification.sh script is actually orphaned - I've cleaned it up in #3064 (the PR for the minor version bump automation)

@ninalee12 ninalee12 force-pushed the update-slack-message branch from 2e866f9 to 05b17dd Compare July 6, 2026 15:52
@ninalee12 ninalee12 requested a review from edsavage July 6, 2026 15:58
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ninalee12 ninalee12 force-pushed the update-slack-message branch from 05b17dd to 85d2156 Compare July 6, 2026 19:23

@edsavage edsavage left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edsavage edsavage merged commit 54929c5 into main Jul 7, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants